Skip to content

Fix SQL error throwed when websiteId is NULL magento/magento2#37284 #39203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: 2.4-develop
Choose a base branch
from
Open

Fix SQL error throwed when websiteId is NULL magento/magento2#37284 #39203

wants to merge 4 commits into from

Conversation

thai2301
Copy link

@thai2301 thai2301 commented Sep 24, 2024 •
edited
Loading

Description (*)

In code is sometimes situation when $websiteId passed to addWebsiteGroupDateFilter is NULL.
Magento\SalesRule\Model\Quote\Address\Total\ShippingDiscount:61 has been using calculator before init.

  1. Fixes [Issue] Fix SQL error throwed when websiteId is NULL #37284

Manual testing scenarios (*)

  1. ...

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant M2 Assistant
Copy link

m2-assistant bot commented Sep 24, 2024

Hi @thai2301. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@thai2301
Copy link
Author

@magento run all tests

@thai2301 thai2301 closed this Sep 24, 2024
@thai2301 thai2301 reopened this Sep 24, 2024
andrewbess
andrewbess approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@andrewbess andrewbess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @thai2301
Thank you for your contribution.
The changes look nice for me
Approved ✅

@andrewbess
Copy link
Contributor

@thai2301
Could you please check and fix unit tests

@thai2301
Copy link
Author

@andrewbess ok I'm on it

@thai2301
Copy link
Author

@magento run Unit Tests

@thai2301
Copy link
Author

@magento run all tests

@engcom-Hotel engcom-Hotel added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 24, 2024
@thai2301
Copy link
Author

@magento run Integration Tests

@thai2301
Copy link
Author

@magento run Functional Tests EE

@thai2301
Copy link
Author

@magento run Functional Tests EE,Functional Tests B2B

@thai2301
Copy link
Author

@magento run Functional Tests B2B

@thai2301
Copy link
Author

@andrewbess please let me know if any changes needed.

@thai2301
Copy link
Author

@magento run all tests

@thai2301
Copy link
Author

@magento run Integration Tests

@thai2301
Copy link
Author

thai2301 commented Oct 8, 2024

@magento run Functional Tests EE

@thai2301
Copy link
Author

thai2301 commented Oct 9, 2024

@magento run Functional Tests B2B

@thai2301
Copy link
Author

@magento run Sample Data Tests CE,Sample Data Tests EE,Adobe CLA Signed?

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@thai2301
Copy link
Author

@magento run Sample Data Tests EE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@thai2301
Copy link
Author

@magento run Functional Tests B2B

@thai2301
Copy link
Author

@magento run all tests

@thai2301
Copy link
Author

@magento run Unit Tests

@thai2301
Copy link
Author

@magento run Functional Tests EE

@thai2301
Copy link
Author

@magento run Sample Data Tests B2B

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@thai2301
Copy link
Author

@magento run Sample Data Tests CE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

@thai2301
Copy link
Author

@magento run Sample Data Tests CE

@magento-automated-testing Magento Automated Testing
Copy link

Failed to run the builds. Please try to re-run them later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewbess andrewbess andrewbess approved these changes

Assignees

@andrewbess andrewbess

Labels
Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: ready for testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Issue] Fix SQL error throwed when websiteId is NULL
3 participants
@thai2301 @andrewbess @engcom-Hotel